Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OUDS] Docs(helpers): add 'Stacks' page #2681

Merged
merged 3 commits into from
Aug 7, 2024
Merged

[OUDS] Docs(helpers): add 'Stacks' page #2681

merged 3 commits into from
Aug 7, 2024

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Aug 7, 2024 •
edited
Loading

Related issues

Listed in #2589.

Description

This PR adds the "Helpers > Stacks" page based on:

To add to #2589

  • Uncomment elements whenever /helpers/vertical-rule is added
  • Uncomment elements whenever buttons are developed
  • Uncomment elements whenever inputs are developed

Types of change

  • New documentation (non-breaking change which adds functionality)

Live previews

@julien-deramond julien-deramond added the docs Improvements or additions to documentation label Aug 7, 2024
@julien-deramond julien-deramond mentioned this pull request Aug 7, 2024
Open
@netlify Netlify
Copy link

netlify bot commented Aug 7, 2024 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit a8602f1
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66b329bd5e54190008f5c981
😎 Deploy Preview https://deploy-preview-2681--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond marked this pull request as ready for review August 7, 2024 06:21
louismaximepiton
louismaximepiton approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the following but I was wondering if the comments should be changed to follow Bootstrap or Boosted version or a ready to uncomment version.

@julien-deramond julien-deramond merged commit 99f651c into ouds/main Aug 7, 2024
12 checks passed
@julien-deramond julien-deramond deleted the ouds/main-jd-helpers-stacks branch August 7, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
[OUDS] Project
Status: Done
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-deramond @louismaximepiton